Repository navigation
fix: crash on windows when v8 posts a delayed worker task during shutdown - #53201
Merged
Conversation
…down Backports nodejs/node#61999. NodePlatform's DelayedTaskScheduler closes its uv loop when the worker thread task runner shuts down, but a task still running on a platform worker thread (V8's MemoryPool release task re-posts itself with a delay) could call PostDelayedTask() after that. The call reaches uv_async_send() on a closed handle; on Windows libuv then fails PostQueuedCompletionStatus() against the destroyed completion port and calls uv_fatal_error(). Late posts are now dropped once the scheduler has been stopped, matching what PerIsolatePlatformData already does for foreground tasks. Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
3 tasks done
codebytere
enabled auto-merge (squash)
August 26, 2026 20:47
VerteDinde
approved these changes
Aug 26, 2026
codebytere
approved these changes
Aug 26, 2026
codebytere
deleted the
trop/44-x-y-bp-fix-crash-on-windows-when-v8-posts-a-delayed-worker-task-during-shutdown-1787746040167
branch
August 26, 2026 21:04
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52956
See that PR for details.
Notes: Fixed a crash on Windows when V8 posted a delayed worker task during shutdown.