Repository navigation
fix: preserve stalled download cancellation for retries - #54
Merged
Merged
Conversation
This was referenced Sep 7, 2026
alexg0
marked this pull request as ready for review
September 7, 2026 04:16
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the download progress monitor cancels a stalled attempt, the cancellation currently looks like a deliberate shutdown and bypasses the transient retry path. Preserve an explicit stall cause with
context.WithCancelCauseso stalled attempts remain retryable and ordinary shutdown cancellation remains non-transient.Extends the paced HTTP stall regression and transient-error table to verify that distinction. This is an independent fix against
main; sustained-stall RPC reporting is separate.Extracted from #52 for independent review and landing ahead of the manifest
feature. #53 is the other independent prerequisite. Order: #53 and #54 → #52
→ #49 → #50 → #51 only if its product scope is accepted. Ready for review.
Validation:
go test ./...,go test -race ./...,go vet ./...,go build ./..., andgit diff --checkall passed locally on Go 1.27.1 (darwin/arm64). The stalled cancellation regression was previously confirmed to fail against the original implementation. No deployment or live service changes were performed.