Avoid some Id clashes by seeding auto-ids with child id - #4840
Merged
Merged
Conversation
ironpeak
marked this pull request as draft
July 17, 2024 17:16
ironpeak
marked this pull request as ready for review
July 17, 2024 17:46
emilk
approved these changes
Aug 26, 2024
Id clashes by seeding auto-ids with child id
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
I was having trouble with id collisions and was not able to resolve it using `push_id` and `child_ui_with_id_source`. When investigating the issue I found emilk#2262 which matched the issues I had so I forked egui and implemented the changes from that PR for the latest version. It solved the issue for me. I did not notice any regressions in my project or the egui web viewer. Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
I was having trouble with id collisions and was not able to resolve it using `push_id` and `child_ui_with_id_source`. When investigating the issue I found emilk#2262 which matched the issues I had so I forked egui and implemented the changes from that PR for the latest version. It solved the issue for me. I did not notice any regressions in my project or the egui web viewer. Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having trouble with id collisions and was not able to resolve it using
push_idandchild_ui_with_id_source.When investigating the issue I found #2262 which matched the issues I had so I forked egui and implemented the changes from that PR for the latest version.
It solved the issue for me.
I did not notice any regressions in my project or the egui web viewer.