Fix Id clash in Frame styling widget - #4967
Merged
Merged
Conversation
As we have two Margin widgets in the same UI and this widget has a Grid with a hardcoded Id, we have to force a different Id to one of them to avoid clashes.
emilk
approved these changes
Aug 26, 2024
Id clash in Frame styling widget
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
As we have two Margin widgets in the same UI and this widget has a Grid with a hardcoded Id, we have to force a different Id to one of them to avoid clashes. * Closes <emilk#4965> * [x] I have followed the instructions in the PR template
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
As we have two Margin widgets in the same UI and this widget has a Grid with a hardcoded Id, we have to force a different Id to one of them to avoid clashes. * Closes <emilk#4965> * [x] I have followed the instructions in the PR template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we have two Margin widgets in the same UI and this widget has a Grid with a hardcoded Id, we have to force a different Id to one of them to avoid clashes.