Fix id clash in Ui::response - #5192
Merged
Merged
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/5192-emilk/use-unique-ui-id |
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
This adds a new `Ui::unique_id` used in `Ui::response`. I'll make a follow-up PR where the old `id` is renamed `stable_id`, and deprecate `fn id` to force users to think through which `id` they want. * Closes emilk#5190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
Ui::unique_idused inUi::response.I'll make a follow-up PR where the old
idis renamedstable_id, and deprecatefn idto force users to think through whichidthey want.Ui::responseonly works ifUiBuilder::id_saltis uniquely set #5190