Fix Ctrl+Shift+Z redo shortcut - #5258
Merged
Merged
Conversation
This shortcut was previously triggering the Undo action due to the matches_logically method ignoring the state of the Shift key. This was solved by simply inverting the undo and redo arms, so the undo is not matched if the shortcut corresponds to redo.
|
Preview available at https://egui-pr-preview.github.io/pr/5258-fix-redo-shortcut |
Contributor
Author
|
Not sure if this is the best solution, or if it would be better to just use Edit: according to the consume_shortcut documentation, the correct approach is to order the shortcuts from most to least "specific" as is done in this PR, so I'm leaving it as is. |
bircni
approved these changes
Oct 13, 2024
bircni
left a comment
Contributor
There was a problem hiding this comment.
lgtm
maybe it would be good to use KeyboardShortcut here
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
This shortcut was previously triggering the Undo action due to the matches_logically method ignoring the state of the Shift key. This was solved by simply inverting the order of the undo and redo arms, so the undo is not matched if the shortcut corresponds to redo. * Closes <emilk#5255> * [x] I have followed the instructions in the PR template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shortcut was previously triggering the Undo action due to the matches_logically method ignoring the state of the Shift key. This was solved by simply inverting the order of the undo and redo arms, so the undo is not matched if the shortcut corresponds to redo.
Ctrl+Shift+Zshould restore data to the state that was before likeCtrl+Ydoes #5255