Add ComboBox::close_behavior - #5305
Merged
Merged
Conversation
Allows changing the close behavior of the underlying popup. For example, to allow a ComboBox with checkboxes to select multiple values without closing.
Added popup example to demonstrate setting ComboBox close behavior, and slightly restructured the rest of the example.
ComboBox::close_behavior
|
Preview available at https://egui-pr-preview.github.io/pr/5305-combobox-close-behavior |
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
Exposed the underlying PopupCloseBehavior of ComboBox in order to allow more control of ComboBox behavior. This allows ComboBox to be used rather than manually managing a popup directly, while also gaining the convenience features of ComboBox such as popup auto-sizing. * [x] I have followed the instructions in the PR template
|
This is my friends PR and I am leaving this comment here because I love OSS and think it's cool when people step up to the plate to contribute, it brings joy! :) @avalsch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposed the underlying PopupCloseBehavior of ComboBox in order to allow more control of ComboBox behavior.
This allows ComboBox to be used rather than manually managing a popup directly, while also gaining the convenience features of ComboBox such as popup auto-sizing.