Skip to content

Implement nohash_hasher::IsEnabled for Id - #5628

Merged
emilk merged 1 commit into
masterfrom
emilk/no-hash-hasher-id-set
Jan 22, 2025
Merged

emilk merged 1 commit into
masterfrom
emilk/no-hash-hasher-id-set

Conversation

@emilk

@emilk emilk commented Jan 22, 2025

Copy link
Copy Markdown
Owner

egui::id::IdSet and egui::id::IdMap were already optimized to not do additional hashing (because the Id already is a hash), but now they are just type aliases for nohash_hasher::IntSet/IntMap.

See https://crates.io/crates/nohash-hasher for more

@emilk emilk changed the title Refactor: use nohash_hasher for IdSet Implement nohash_hasher::IsEnabled for Id Jan 22, 2025
@github-actions

Copy link
Copy Markdown

Preview available at https://egui-pr-preview.github.io/pr/5628-emilkno-hash-hasher-id-set
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@emilk
emilk merged commit 71f7bdc into master Jan 22, 2025
@emilk
emilk deleted the emilk/no-hash-hasher-id-set branch January 22, 2025 12:18
@emilk emilk added the feature New feature or request label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

egui feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant