Select all text in DragValue when gaining focus via keyboard - #7107
Merged
Merged
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/7107-dragvalue-focus-tab |
lucasmerlin
reviewed
Jun 2, 2025
lucasmerlin
left a comment
Collaborator
There was a problem hiding this comment.
Nice! Maybe you can add a private DragValue::select_all or something to deduplicate the selection code?
Azkellas
force-pushed
the
dragvalue-focus-tab
branch
from
June 2, 2025 20:46
709f158 to
92da40b
Compare
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
DragValuewidget selected all text when focus was gained via a mouse click, but didn't when focus was gained via keyboard.egui_old.mp4
This PR makes both gained focus behaving the same way by selecting the text on focus gained via keyboard.
egui_new.mp4