Skip to content

Use the new Popup api for the color picker button - #7137

Merged
emilk merged 3 commits into
mainfrom
lucas/color-picker-popup
Jun 18, 2025
Merged

Use the new Popup api for the color picker button#7137
emilk merged 3 commits into
mainfrom
lucas/color-picker-popup

Conversation

@lucasmerlin

@lucasmerlin lucasmerlin commented Jun 12, 2025

Copy link
Copy Markdown
Collaborator

The color picker popup is now aligned to the bottom left edge (instead of the bottom right), but I think this makes more sense and is aligned with ComboBox etc. It also gets the new nice auto positioning.

@github-actions

github-actions Bot commented Jun 12, 2025

Copy link
Copy Markdown

Preview available at https://egui-pr-preview.github.io/pr/7137-lucascolor-picker-popup
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@lucasmerlin lucasmerlin added feature New feature or request egui labels Jun 12, 2025
@lucasmerlin lucasmerlin changed the title Use the new Popup api in color picker Use the new Popup api for the color picker button Jun 12, 2025
emilk
emilk requested changes Jun 15, 2025
View reviewed changes

@emilk emilk left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The color picker closes on each click within it now. It should only close one escape and when clicking outside of it.

@lucasmerlin
lucasmerlin requested a review from emilk June 16, 2025 06:41
@emilk

emilk commented Jun 16, 2025

Copy link
Copy Markdown
Owner

https://egui-pr-preview.github.io/pr/7137-lucascolor-picker-popup/ still closes when I click within the color picker

@lucasmerlin

lucasmerlin commented Jun 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

egui-pr-preview.github.io/pr/7137-lucascolor-picker-popup still closes when I click within the color picker

That's so weird. It doesn't do it when I run it natively:

Screen.Recording.2025-06-18.at.09.14.44.mov

Maybe something went wrong when updating the preview app? A race condition?

Edit: I redeployed and now it works in the preview. Must've been a fluke.

@emilk
emilk merged commit c8b844c into main Jun 18, 2025
@emilk
emilk deleted the lucas/color-picker-popup branch June 18, 2025 17:19
@emilk emilk mentioned this pull request Jul 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilk emilk emilk approved these changes
+1 more reviewer
@bircni bircni bircni approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

egui feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update color picker buttons to the new popup api

3 participants

@lucasmerlin @emilk @bircni