Improve text rendering in light mode - #7290
Merged
Merged
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/7290-emilkimprove-light-mode-text |
emilk
marked this pull request as ready for review
July 2, 2025 12:00
Wumpf
approved these changes
Jul 2, 2025
Wumpf
left a comment
Collaborator
There was a problem hiding this comment.
If nothing else it's now a lot easier to understand what's happening and why, nice!!
Tested the looks on low-dpi SDR Windows Firefox: I found the default settings a tad bit too light, empirically a gamma of 0.9 looked a lil bit better to me. But this is starting to get arbitrary so if you think linear looks good I'm very much in favor with sticking with that
Either way I also believe this to be an improvement compared the harsh and fringy looking boundaries of TwoCoverageMinusCoverageSq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes how we convert glyph coverage to alpha (and ultimately a color), but only in light mode.
This is a bit of a hack, because it doesn't fix dark-on-light text in dark mode (if you have any), but for the common case this PR is a huge improvement.
You can also tweak this yourself now using
Visuals::text_alpha_from_coverageor from the UI (bottom of the image):Before / After
Black text Before/after
If you think the text above looks too weak, it's only because of the default text color. Here's how it looks like with perfectly
#000000black text: