Respect the menu style config in sub menus - #8572
Open
lucasmerlin wants to merge 3 commits into
Open
lucasmerlin wants to merge 3 commits into
lucasmerlin wants to merge 3 commits into
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/8572-lucasrespect-child-menustyle-in-popup View snapshot changes at kitdiff |
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
emilk
approved these changes
Sep 16, 2026
| content: impl FnOnce(&mut Ui) -> R, | ||
| ) -> Option<InnerResponse<R>> { | ||
| let frame = Frame::menu(ui.style()); | ||
| let measurement_frame = Frame::menu(ui.style()); |
Owner
There was a problem hiding this comment.
this is a bit of a weird name - maybe add a comment to it?
Owner
There was a problem hiding this comment.
I would like to also see what style a sub-sub menu gets now. Does it inherit it from the closest ancestor, i.e. also become red with green outline?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it was ignored since menu_style was applied within
Popupand the frame was created on the previous, unchanged outer ui.