Change force to be Option<f32> instead of f32 - #3240
Merged
Merged
Conversation
emilk
approved these changes
Aug 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force being 0 having two meanings makes it hard to tell whether it has just been a very light touch or whether no force is provided.
In my drawing app I draw a thick line when pressure is close to 1 or the device has no pressure and a thin line when pressure is close to 0.
Not being able to tell between 0 and None causes bugs where faint strokes suddenly have thick blobs when pressure reaches 0. This could be avoided with some clever logic but the changes in this PR make it a lot easier.
There also is a force variable in
MultiTouchInfobut I don't think that one needs to be changed to Option since it's an average. But I could also update it for consitency.