Final polish for new image loading - #3328
Merged
Merged
Conversation
jprochazk
marked this pull request as ready for review
September 13, 2023 08:46
This was referenced Sep 13, 2023
emilk
requested changes
Sep 13, 2023
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Sep 13, 2023
<!-- Open the PR up as a draft until you feel it is ready for a proper review. Do not make PR:s from your own `main` branch, as that makes it difficult for reviewers to add their own fixes. Add any improvements to the branch as new commits to make it easier for reviewers to follow the progress. All commits will be squashed to a single commit once the PR is merged into `main`. Make sure you mention any issues that this PR closes in the description, as well as any other related issues. To get an auto-generated PR description you can put "copilot:summary" or "copilot:walkthrough" anywhere. --> ### What - Update `egui` to point to latest commit on emilk/egui#3328 - Remove `StaticImageCache`, as its a part of `egui` now - Update icons to use `egui::Image` ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3311) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3311) - [Docs preview](https://rerun.io/preview/5fd7b59260f843d1f2fab710b8f719b368a3f039/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/5fd7b59260f843d1f2fab710b8f719b368a3f039/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3291
Cow<'static, str>instead of only&'static strforImageSource::BytesURIsRetainedImage#![allow(deprecated)]remaining inegui_extras::imageitself.#[doc(hidden)]toegui_extras::imageRawImageinButtonwith justImageRawImageStyleoption for wether or not an image should show a spinner while loading (see Welcome + Examples screen design touch-ups rerun-io/rerun#3244)