Skip to content

egui: add redo support to Undoer - #3478

Merged
emilk merged 3 commits into
emilk:masterfrom
LoganDark:redo
Nov 10, 2023
Merged

emilk merged 3 commits into
emilk:masterfrom
LoganDark:redo

Conversation

@LoganDark

@LoganDark LoganDark commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

Better implementation than #3448. (by accident since I did not see that PR)

@LoganDark LoganDark changed the title Add redo support to Undoer egui: add redo support to Undoer Oct 17, 2023
@LoganDark

Copy link
Copy Markdown
Contributor Author

Honestly no idea why the labels check is failing. Either that or it means actual github labels which I don't have permission to apply.

@LoganDark

Copy link
Copy Markdown
Contributor Author

Hey @emilk what would it take to get this merged?

Comment thread crates/egui/src/widgets/text_edit/builder.rs Outdated
@emilk

emilk commented Nov 10, 2023

Copy link
Copy Markdown
Owner

Better implementation than #3448

Better how?

@LoganDark

Copy link
Copy Markdown
Contributor Author

Better implementation than #3448

Better how?

AFAIK this implementation just seemed more straightforward to me. I've since forgot the exact reason, though.

@LoganDark

Copy link
Copy Markdown
Contributor Author

Sigh. I literally ran cargo cranky. Not very cranky if it doesn't check formatting.

@LoganDark

Copy link
Copy Markdown
Contributor Author

In my own application, I have a variation of change history that allows you to have multiple redo stacks and switch between them, rather than them being cleared whenever you perform an action. However, that usually requires supporting UI, and isn't always intuitive to people, which is why I don't think it's right for egui to implement that itself. However, TextEdit makes it difficult to replace the default undo and redo actions with it. Not sure if there is an easy solution.

@emilk emilk added the egui label Nov 10, 2023

@emilk emilk left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emilk
emilk merged commit 5201c04 into emilk:master Nov 10, 2023
@LoganDark
LoganDark deleted the redo branch November 10, 2023 20:36
@emilk emilk changed the title egui: add redo support to Undoer egui: add redo support to Undoer Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add redo to Undoer

2 participants