#11930 - rewrite packages\ketcher-react\src\script\ui\action\copyImageToClipboard.js from JavaScript to TypeScript - #11944
Open
armankarapetyan-svg wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Files Created:
types.ts (new file)
Defined CurrentAppState interface that types the global currentState variable
Contains editor (KetcherEditor) and options (OptionsState) properties
Eliminates implicit any types for the global state
copyImageToClipboard.ts (converted from .js)
Renamed file extension from .js to .ts
Added return type annotation Promise to function
All variables have explicit types:
state: CurrentAppState - types the global state
editor: KetcherEditor - imported from ketcher-core
options: OptionsState - imported from store.types
struct: Struct - return type of structSelected()
errorHandler: ((message: string) => void) | null - from editor
structStr: string - serialized structure
generateImageOptions: GenerateImageOptions - from ketcher-core
image: Blob - return type of generateImage()
e: unknown - catch block error (safer than any)
Added global Window interface declaration to properly type global.currentState
Imported GenerateImageOptions from ketcher-core for type compatibility
Added null check for errorHandler before calling
Files Removed:
copyImageToClipboard.js (original JavaScript file)
Check list
#1234 – issue name