Upgrade terraform-provider-equinix to v1.37.0#97
Conversation
Does the PR have any schema changes?Does the PR have any schema changes?Found 10 breaking changes: Types
New functions:
Maintainer note: consult the runbook for dealing with any breaking changes. |
There was a problem hiding this comment.
Although I think it's not a problem, you shouldn't add MaxItemsOne on all fields, it's a workaround for TypeSet/TypeList attributes which are actually a single nested object (terraform sdkv2 schema behavior), since pulumi renames them to their plural form (Pagnitation --> Paginations) if they do not have a Maxitems=1 defined in the terraform side. So we should really fix the problem on the Terraform side, instead of continuing to make the schema more complex on the Pulumi side.
Unless you know there's a TypeSet/List field in any of the new resources where we missed MaxItems=1, you can omit the whole Fields definition in all new resources/datasources:
"equinix_fabric_cloud_routers": {Tok: makeEquinixDataSource(fabricMod, "CloudRouters")},
We will remove the manual overrides and that we'll take a look into our schemas to have this updated when we can. Now that it's on our radar and we'll manage Pulumi in a more dedicated way. |
ocobles
left a comment
There was a problem hiding this comment.
lgtm, Im going to open a new issue to track the changes for the MaxItemsOne attribute
This PR was generated via
$ upgrade-provider equinix/pulumi-equinix --upstream-provider-name terraform-provider-equinix.