Skip to content

Upgrade terraform-provider-equinix to v1.37.0#97

Merged
ocobles merged 2 commits into
mainfrom
upgrade-terraform-provider-equinix-to-v1.37.0
Jun 18, 2024
Merged

Upgrade terraform-provider-equinix to v1.37.0#97
ocobles merged 2 commits into
mainfrom
upgrade-terraform-provider-equinix-to-v1.37.0

Conversation

@srushti-patl

Copy link
Copy Markdown
Contributor

This PR was generated via $ upgrade-provider equinix/pulumi-equinix --upstream-provider-name terraform-provider-equinix.


  • Upgrading terraform-provider-equinix from 1.36.4 to 1.37.0.
  • Upgrading pulumi-terraform-bridge from v3.82.0 to v3.84.0.
  • Upgrading pulumi-terraform-bridge/pf from v0.35.0 to v0.37.0.

@srushti-patl srushti-patl self-assigned this Jun 13, 2024
@srushti-patl srushti-patl requested a review from a team June 13, 2024 23:44
@github-actions

Copy link
Copy Markdown

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 10 breaking changes:

Types

  • "equinix:networkedge/getDeviceClusterDetailNode0VendorConfiguration:getDeviceClusterDetailNode0VendorConfiguration": required:
    • 🟢 "licenseId" property has changed to Required
    • 🟢 "licenseKey" property has changed to Required
    • 🟢 "privateAddress" property has changed to Required
    • 🟢 "privateCidrMask" property has changed to Required
    • 🟢 "privateGateway" property has changed to Required
  • "equinix:networkedge/getDeviceClusterDetailNode1VendorConfiguration:getDeviceClusterDetailNode1VendorConfiguration": required:
    • 🟢 "licenseId" property has changed to Required
    • 🟢 "licenseKey" property has changed to Required
    • 🟢 "privateAddress" property has changed to Required
    • 🟢 "privateCidrMask" property has changed to Required
    • 🟢 "privateGateway" property has changed to Required

New functions:

  • fabric/getCloudRouters.getCloudRouters
  • fabric/getConnections.getConnections
  • fabric/getNetworks.getNetworks

Maintainer note: consult the runbook for dealing with any breaking changes.

@ocobles ocobles left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I think it's not a problem, you shouldn't add MaxItemsOne on all fields, it's a workaround for TypeSet/TypeList attributes which are actually a single nested object (terraform sdkv2 schema behavior), since pulumi renames them to their plural form (Pagnitation --> Paginations) if they do not have a Maxitems=1 defined in the terraform side. So we should really fix the problem on the Terraform side, instead of continuing to make the schema more complex on the Pulumi side.

Unless you know there's a TypeSet/List field in any of the new resources where we missed MaxItems=1, you can omit the whole Fields definition in all new resources/datasources:

"equinix_fabric_cloud_routers": {Tok: makeEquinixDataSource(fabricMod, "CloudRouters")},

@srushti-patl

Copy link
Copy Markdown
Contributor Author

Although I think it's not a problem, you shouldn't add MaxItemsOne on all fields, it's a workaround for TypeSet/TypeList attributes which are actually a single nested object (terraform sdkv2 schema behavior), since pulumi renames them to their plural form (Pagnitation --> Paginations) if they do not have a Maxitems=1 defined in the terraform side. So we should really fix the problem on the Terraform side, instead of continuing to make the schema more complex on the Pulumi side.

Unless you know there's a TypeSet/List field in any of the new resources where we missed MaxItems=1, you can omit the whole Fields definition in all new resources/datasources:

"equinix_fabric_cloud_routers": {Tok: makeEquinixDataSource(fabricMod, "CloudRouters")},

We will remove the manual overrides and that we'll take a look into our schemas to have this updated when we can. Now that it's on our radar and we'll manage Pulumi in a more dedicated way.
Can we release the latest version without including these changes?

@ocobles ocobles left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Im going to open a new issue to track the changes for the MaxItemsOne attribute

@ocobles ocobles merged commit 9d4f110 into main Jun 18, 2024
@ocobles ocobles deleted the upgrade-terraform-provider-equinix-to-v1.37.0 branch June 18, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants