fix: sweep only test - #1044
Open
tng1-equinix wants to merge 3 commits into
Open
fix: sweep only test#1044tng1-equinix wants to merge 3 commits into
tng1-equinix wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent Fabric sweeper jobs from deleting resources created by other parallel acceptance test suites by scoping sweeping to a specific test “target” via an environment variable.
Changes:
- Added
SWEEP_TARGET-based filtering to Fabric sweeper resource-name matching. - Set
SWEEP_TARGETvalues in the Fabric acceptance-test GitHub Actions workflow sweeper steps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
internal/sweep/sweep.go |
Introduces SWEEP_TARGET filtering for determining which Fabric test resources are sweepable. |
.github/workflows/fabric_acctest.yml |
Sets SWEEP_TARGET per sweeper job to scope deletion to the corresponding test suite. |
Comment on lines
+30
to
+32
| if v := os.Getenv("SWEEP_TARGET"); v != "" { | ||
| return strings.HasSuffix("_"+resourceName, v) | ||
| } |
WORKFLOW-25 · Pull Request Comments for Secrets ScanningWorkflows: "WORKFLOW-25 · Pull Request Comments for Secrets Scanning"
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
===========================================
+ Coverage 28.27% 72.52% +44.24%
===========================================
Files 175 175
Lines 21742 21744 +2
===========================================
+ Hits 6148 15769 +9621
+ Misses 15465 5084 -10381
- Partials 129 891 +762 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Closed
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: tng1-equinix <tng1@ap.equinix.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With our current pipeline, it is possible (likely even), that a test suite ends earlier than the other, which causes it to sweep all of the resources, which causes another test suite to fail