erts: Implement BIFs pid_to_binary/1, port_to_binary/1, ref_to_binary/1 - #11668

CT Test Results

     7 files     622 suites   3h 2m 35s ⏱️
 6 370 tests  5 825 ✅ 545 💤 0 ❌
12 690 runs  12 061 ✅ 629 💤 0 ❌

Results for commit 4274b22.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• Windows Installer

// Erlang/OTP Github Action Bot

If we add x_to_binary/1 should we not also have binary_to_x/1?

Your two commits are in a strange order. The update of preloaded files precedes the implementation of the BIFs. Please put them in the correct order and make sure that erlang.beam is compiled from your updated erlang.erl.

If we add x_to_binary/1 should we not also have binary_to_x/1?

Yes, in the general case, but the conversion from lists to pids, ports, or refs are only meant for debugging, not for production code. I think it's enough to be able to construct these terms from lists.

I think it's enough to be able to construct these terms from lists.

sure, but it is also nice to not have to remember which terms have a binary_to_term and which do not.