ci: fix broken release-create for OTP-26/27 asset upload - #11670
Open
kikofernandez wants to merge 1 commit into
Open
kikofernandez wants to merge 1 commit into
kikofernandez wants to merge 1 commit into
Conversation
The "Create Release for 26 and 27" step spliced two commands into one malformed invocation on the create (release-does-not-exist) path:
gh release create "${TAG}" --title "OTP ${VSN}" --latest=false \
gh release upload "${TAG}" --clobber \
artifacts/*.tar.gz \
artifacts/*.txt
The trailing backslash continued the `create` line onto the `upload` line, so the shell ran a single command with `gh release upload ...` passed as positional asset arguments to `gh release create`, then hit `--clobber` (not a valid flag for create). The command always exited non-zero, so first-time OTP-26/27 tags never produced a GitHub release or published their .tar.gz/.txt assets.
`gh release create` accepts asset files as positional arguments, so no separate upload is needed on the create path. Drop the stray upload command and pass the globs directly to create, mirroring the working OTP-28+ step. `--latest=false` is retained (26/27 must not be marked latest, unlike 28+ which uses the computed LATEST value).
Contributor
CT Test Results 1 files 11 suites 3m 36s ⏱️ Results for commit ca7a711. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Create Release for 26 and 27" step spliced two commands into one malformed invocation on the create (release-does-not-exist) path:
The trailing backslash continued the
createline onto theuploadline, so the shell ran a single command withgh release upload ...passed as positional asset arguments togh release create, then hit--clobber(not a valid flag for create). The command always exited non-zero, so first-time OTP-26/27 tags never produced a GitHub release or published their .tar.gz/.txt assets.gh release createaccepts asset files as positional arguments, so no separate upload is needed on the create path. Drop the stray upload command and pass the globs directly to create, mirroring the working OTP-28+ step.--latest=falseis retained (26/27 must not be marked latest, unlike 28+ which uses the computed LATEST value).