Conversation
daemon_info/1 passed #address.address (normally an IP tuple or the
atom 'any'/'loopback') straight to inet:parse_strict_address/1,
relying on the old {error, einval} return for non-string input.
OTP-20357 made that call crash with function_clause.
Only parse strings/binaries; leave tuples and atoms as-is. This is
behaviour-preserving and drops ssh's dependence on the parser
tolerating wrong-type arguments.
Contributor
CT Test Results 2 files 27 suites 10m 49s ⏱️ Results for commit 6c84334. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daemon_info/1 passed #address.address (normally an IP tuple or the atom 'any'/'loopback') straight to inet:parse_strict_address/1, relying on the old {error, einval} return for non-string input. OTP-20357 made that call crash with function_clause.
Only parse strings/binaries; leave tuples and atoms as-is. This is behaviour-preserving and drops ssh's dependence on the parser tolerating wrong-type arguments.