Repository navigation
Conversation
eseidel
force-pushed
the
fix/shop-description-logic
branch
from
April 1, 2026 05:00
e9aa917 to
c77bdff
Compare
…tion logic to logic layer Shop purchases containing equipment items with modifiers (e.g., Warm Beanie) were showing no description. Moved all shop description generation from UI into ShopPurchase.shopDescription() in the logic layer, with a priority chain: custom description > item charges > purchase modifiers > item description > item modifier descriptions. Also consolidated the duplicated _formatModifiers pattern from bank/equipment/shop into ModifierMetadataRegistry.formatModifierDescriptions().
eseidel
force-pushed
the
fix/shop-description-logic
branch
from
April 1, 2026 05:02
c77bdff to
d19acd4
Compare
eseidel
enabled auto-merge (squash)
April 1, 2026 05:03
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
+ Coverage 90.11% 90.13% +0.02%
==========================================
Files 108 108
Lines 14673 14716 +43
==========================================
+ Hits 13222 13265 +43
Misses 1451 1451
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShopPurchase.shopDescription()in the logic layer, resolving descriptions via a priority chain: custom description → item charges → purchase modifiers → item description → item modifier descriptions_formatModifiers(Item, Registry)pattern (copy-pasted in bank.dart, equipment_stats_dialog.dart) intoModifierMetadataRegistry.formatModifierDescriptions()Test plan
ShopPurchase.shopDescriptioncovering all priority levels and edge casesModifierMetadataRegistry.formatModifierDescriptionsdart analyze --fatal-infosclean on all changed files