ci: skip EMFILE test on Node.js 26 - #21265
Merged
Merged
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
EMFILE test on Node.js 26.8+
lumirlumir
marked this pull request as ready for review
August 28, 2026 09:37
This was referenced Aug 28, 2026
mdjermanovic
approved these changes
Aug 29, 2026
mdjermanovic
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! I'm going to merge this temporary solution to unblock CI.
Comment on lines
+94
to
+97
| # Node.js 26.8+ no longer reliably triggers `EMFILE` for small-file reads. | ||
| # See: https://github.com/nodejs/node/pull/65327 | ||
| # TODO: Re-enable after replacing this with deterministic error injection. | ||
| if: matrix.node != '26.x' |
Member
There was a problem hiding this comment.
@lumirlumir can you please open an issue so we can track this and figure out how to re-enable this check?
3 tasks
3 tasks
huskas-2189
pushed a commit
to huskas-2189/Bookmark
that referenced
this pull request
Sep 6, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | [`10.9.1` → `10.10.0`](https://renovatebot.com/diffs/npm/eslint/10.9.1/10.10.0) |  |  | --- ### Release Notes <details> <summary>eslint/eslint (eslint)</summary> ### [`v10.10.0`](https://github.com/eslint/eslint/releases/tag/v10.10.0) [Compare Source](eslint/eslint@v10.9.1...v10.10.0) #### Features - [`264b434`](eslint/eslint@264b434) feat: add `d` and `v` flags to `no-unexpected-multiline` ([#​21305](eslint/eslint#21305)) (Gihyeon Jeong / 정기현) - [`c6cc6c5`](eslint/eslint@c6cc6c5) feat: check `Object.prototype` property names in `new-cap` ([#​21269](eslint/eslint#21269)) (crimsonjay0) - [`5661fa6`](eslint/eslint@5661fa6) feat: no-extra-bind false negatives with class fields and static blocks ([#​21260](eslint/eslint#21260)) (synthex-byte) #### Bug Fixes - [`bb47dc6`](eslint/eslint@bb47dc6) fix: update dependency file-entry-cache to v11 ([#​20801](eslint/eslint#20801)) (Milos Djermanovic) - [`427ac0a`](eslint/eslint@427ac0a) fix: use format strings in debug calls ([#​21247](eslint/eslint#21247)) (Francesco Trotta) - [`9d81532`](eslint/eslint@9d81532) fix: support `__proto__` in `/* exported */` comments ([#​21261](eslint/eslint#21261)) (sethamus) - [`87e0a08`](eslint/eslint@87e0a08) fix: prefer-object-has-own autofix breaks when Object is shadowed ([#​21282](eslint/eslint#21282)) (김채영) - [`8e2cb14`](eslint/eslint@8e2cb14) fix: `new-cap` false positive for `UTC` calls with `properties: false` ([#​21275](eslint/eslint#21275)) (Pixel) - [`9f4a364`](eslint/eslint@9f4a364) fix: Ignore static imports in no-unreachable ([#​21276](eslint/eslint#21276)) (Taha Kotil) #### Documentation - [`2417cad`](eslint/eslint@2417cad) docs: Update README (GitHub Actions Bot) - [`9cecb8a`](eslint/eslint@9cecb8a) docs: document `\c` control letter escapes in no-control-regex ([#​21286](eslint/eslint#21286)) (한국) - [`8724829`](eslint/eslint@8724829) docs: update compat table links ([#​21263](eslint/eslint#21263)) (fnx) - [`5634542`](eslint/eslint@5634542) docs: Clarify eqeqeq suggestion behavior ([#​21256](eslint/eslint#21256)) (Müslüm Yılmaz) #### Chores - [`b3d876b`](eslint/eslint@b3d876b) chore: disable npm audit in ecosystem tests ([#​21306](eslint/eslint#21306)) (Francesco Trotta) - [`1696682`](eslint/eslint@1696682) ci: restore EMFILE test on Node.js 26 ([#​21297](eslint/eslint#21297)) (Marry (Subin Yang)) - [`2c7f5d6`](eslint/eslint@2c7f5d6) chore: update github/codeql-action action to v4.37.9 ([#​21296](eslint/eslint#21296)) (renovate\[bot]) - [`3c753f1`](eslint/eslint@3c753f1) chore: update eslint ([#​21289](eslint/eslint#21289)) (renovate\[bot]) - [`1c73469`](eslint/eslint@1c73469) chore: update ecosystem plugins ([#​21280](eslint/eslint#21280)) (ESLint Bot) - [`08a02be`](eslint/eslint@08a02be) test: add error locations to `no-extra-boolean-cast` ([#​21266](eslint/eslint#21266)) (lumir) - [`77bb1db`](eslint/eslint@77bb1db) chore: update github/codeql-action action to v4.37.8 ([#​21270](eslint/eslint#21270)) (renovate\[bot]) - [`007e81a`](eslint/eslint@007e81a) ci: skip EMFILE test on Node.js 26 ([#​21265](eslint/eslint#21265)) (lumir) - [`0430280`](eslint/eslint@0430280) chore: improve ecosystem tests compatibility on Windows ([#​21178](eslint/eslint#21178)) (crimsonjay0) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNjEuMiIsInVwZGF0ZWRJblZlciI6IjQzLjI2MS4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119--> Reviewed-on: https://codeberg.org/huskas-2189/Bookmark/pulls/261
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
Temporarily skipped the
EMFILEtest on Node.js 26 because Node.js 26.8+ no longer reliably triggersEMFILEfor small-file reads.The test continues to run on other Node.js versions.
Is there anything you'd like reviewers to focus on?
I think this issue was caused by nodejs/node#65327 in Node.js, which is included in Node.js 26.8.0.
The PR is performance-related, so reading many files no longer seems to trigger an
EMFILEerror.I’m not sure whether this is a regression in Node.js, but I think the issue is that we’ve been relying on the
EMFILEerror as a heuristic for throwing the error.I haven’t been able to find a reliable solution yet, so I’m leaving this workaround in place for now to avoid blocking other PRs because of this issue.