Add Object::TimeToCollision and SE_GetTimeToCollision API#821
Closed
kosuke55 wants to merge 3 commits into
Closed
Conversation
kosuke55
force-pushed
the
feat/get-time-to-collision-api
branch
from
July 2, 2026 14:27
2aa02d5 to
255e7e9
Compare
Contributor
Author
|
@eknabevcc |
kosuke55
force-pushed
the
feat/get-time-to-collision-api
branch
from
July 16, 2026 13:13
255e7e9 to
f1bae24
Compare
kosuke55
force-pushed
the
feat/get-time-to-collision-api
branch
from
July 16, 2026 13:17
f1bae24 to
d19a7dd
Compare
kosuke55
force-pushed
the
feat/get-time-to-collision-api
branch
from
July 16, 2026 13:19
d19a7dd to
396d1ae
Compare
Contributor
Author
|
Ah sorry, fixed the clang-format CI. |
Collaborator
|
FYI: We're looking into this nice contribution. For example, will fix the C# wrapper. |
eknabevcc
pushed a commit
that referenced
this pull request
Jul 16, 2026
- move ttc calculations from condition to Object class - expose it by adding SE_GetTimeToCollision to esminiLib
Collaborator
|
Thanks for this nice improvement! Since I haven't learnt fully how to operate on PR itself, I squashed your commits and fixed the C# wrapper (into a single commit a08a439 with you as author) in a separate branch. It's now merged on dev and will hence be included in next release. Closing the PR (unfortunately it will wrongly look like not merged) |
Contributor
Author
|
Thank you for taking the time to review and merge it! Really appreciate the C# wrapper fix too. |
Collaborator
|
Included in v3.6.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the great project!
Add time-to-collision computation as
Object::TimeToCollisionand expose it viaSE_GetTimeToCollisionin esminiLib.TrigByTimeToCollision::CheckConditiondelegates the object-to-object path to the new method (no behavior change).