Fix NaturalDriver crash when running without a ScenarioPlayer - #828
Open
kosuke55 wants to merge 2 commits into
Open
Fix NaturalDriver crash when running without a ScenarioPlayer #828kosuke55 wants to merge 2 commits into
kosuke55 wants to merge 2 commits into
Conversation
kosuke55
force-pushed
the
fix/natural-driver-null-player
branch
from
July 28, 2026 15:07
5822e87 to
1e0806e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reports the issue and proposes a possible fix. I’m happy to follow whichever approach the maintainers prefer.
ControllerNaturalDriver::Step()injects lane changes viaplayer_->player_server_, which isnullptrin headless library mode (e.g. esminiJS drives theScenarioEnginedirectly). The first lane change inhighway_driver.xoscthen crashes.Fix: add a generic
ScenarioEngine::AddInjectedAction(OSCAction*)backed by an engine-owned list, used when noPlayerServerlist is registered. The controller builds theLatLaneChangeActionand injects it through this entry point when no player exists. The native path is unchanged (PlayerBase/untouched).Includes a unit test that crashes without the fix.