Skip to content

refactor: remove some useless code - #6118

Merged
Josh-Cena merged 1 commit into
mainfrom
lex111/remove-dead-code
Dec 17, 2021
Merged

Josh-Cena merged 1 commit into
mainfrom
lex111/remove-dead-code

Conversation

@lex111

@lex111 lex111 commented Dec 16, 2021

Copy link
Copy Markdown
Contributor

Motivation

Just a little cleaning up of codebase.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Dec 16, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 16, 2021
@netlify

netlify Bot commented Dec 16, 2021

Copy link
Copy Markdown

✔️ [V2]

🔨 Explore the source changes: 7c33f2c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61bba8027fc74f000741b6e2

😎 Browse the preview: https://deploy-preview-6118--docusaurus-2.netlify.app

@github-actions

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 89
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6118--docusaurus-2.netlify.app/

@github-actions

Copy link
Copy Markdown

Size Change: -27 B (0%)

Total Size: 652 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 37.8 kB 0 B
website/build/assets/css/styles.********.css 101 kB 0 B
website/build/assets/js/main.********.js 484 kB -27 B (0%)
website/build/index.html 29.3 kB 0 B

compressed-size-action

@Josh-Cena

Copy link
Copy Markdown
Collaborator

Just wondering: where was useLocationHash used previously? Could it actually be useful in some cases and be added to theme-common?

@lex111

lex111 commented Dec 17, 2021

Copy link
Copy Markdown
Contributor Author

Don't think we need this hook, it's too specific, usually useLocationChange covers all needs.

@Josh-Cena
Josh-Cena merged commit 6ab4efe into main Dec 17, 2021
@Josh-Cena
Josh-Cena deleted the lex111/remove-dead-code branch December 17, 2021 07:41
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants