Skip to content

test: use snapshots for sidebar tests - #6123

Merged
slorber merged 1 commit into
mainfrom
jc/make-snapshot
Dec 17, 2021
Merged

slorber merged 1 commit into
mainfrom
jc/make-snapshot

Conversation

@Josh-Cena

Copy link
Copy Markdown
Collaborator

Motivation

Snapshots are easier to update with no sacrifice in ensuring no regression. It also makes the test file easier to navigate.

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Dec 17, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 17, 2021
@netlify

netlify Bot commented Dec 17, 2021

Copy link
Copy Markdown

✔️ [V2]

🔨 Explore the source changes: 3360f4c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61bc89b45baf2e00081d925e

😎 Browse the preview: https://deploy-preview-6123--docusaurus-2.netlify.app

@github-actions

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 94
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6123--docusaurus-2.netlify.app/

@github-actions

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 652 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 37.8 kB
website/build/assets/css/styles.********.css 101 kB
website/build/assets/js/main.********.js 484 kB
website/build/index.html 29.3 kB

compressed-size-action

@slorber

slorber commented Dec 17, 2021

Copy link
Copy Markdown
Collaborator

👍 thanks

@slorber
slorber merged commit 74aa872 into main Dec 17, 2021
@slorber
slorber deleted the jc/make-snapshot branch December 17, 2021 17:17
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants