Skip to content

test: improve test coverage; properly test core client APIs - #6905

Merged
Josh-Cena merged 2 commits into
mainfrom
jc/improve-test
Mar 12, 2022
Merged

Josh-Cena merged 2 commits into
mainfrom
jc/improve-test

Conversation

@Josh-Cena

Copy link
Copy Markdown
Collaborator

Motivation

We are finally clear of jest.mock usage! Should help with migration to ESM. #6520

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 12, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 12, 2022
@netlify

netlify Bot commented Mar 12, 2022

Copy link
Copy Markdown

✔️ [V2]

🔨 Explore the source changes: 7583708

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/622cb6538bdd4700083489d4

😎 Browse the preview: https://deploy-preview-6905--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Mar 12, 2022

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 59
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6905--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena changed the title test: improve test coverage test: improve test coverage; properly test core client APIs Mar 12, 2022
@github-actions

github-actions Bot commented Mar 12, 2022

Copy link
Copy Markdown

Size Change: +25 B (0%)

Total Size: 792 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 49.9 kB 0 B
website/build/assets/css/styles.********.css 105 kB 0 B
website/build/assets/js/main.********.js 599 kB +25 B (0%)
website/build/index.html 38.7 kB 0 B

compressed-size-action

@Josh-Cena
Josh-Cena merged commit d85cee5 into main Mar 12, 2022
@Josh-Cena
Josh-Cena deleted the jc/improve-test branch March 12, 2022 15:15
@slorber

slorber commented Mar 16, 2022

Copy link
Copy Markdown
Collaborator

thanks, looks nice 👍

mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants