Skip to content

chore: disable string escaping in snapshots - #7131

Merged
Josh-Cena merged 1 commit into
mainfrom
jc/serialize-snapshot
Apr 8, 2022
Merged

Josh-Cena merged 1 commit into
mainfrom
jc/serialize-snapshot

Conversation

@Josh-Cena

Copy link
Copy Markdown
Collaborator

Motivation

See prettier/prettier#12612. This will make the snapshots even more copy/pastable!

In addition, I've added strip-ansi to our snapshot serializer, so that when snapshotting console output we won't care about the actual ANSI coloring being applied.

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Apr 8, 2022
@Josh-Cena
Josh-Cena requested review from lex111 and slorber as code owners April 8, 2022 03:05
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 8, 2022
@netlify

netlify Bot commented Apr 8, 2022

Copy link
Copy Markdown

[V2]

Name Link
🔨 Latest commit 95f68ee
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/624fa6741e2a93000921062d
😎 Deploy Preview https://deploy-preview-7131--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions

github-actions Bot commented Apr 8, 2022

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 65
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7131--docusaurus-2.netlify.app/

@github-actions

github-actions Bot commented Apr 8, 2022

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 805 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 612 kB
website/build/index.html 38.6 kB

compressed-size-action

@Josh-Cena
Josh-Cena merged commit 9145ae8 into main Apr 8, 2022
@Josh-Cena
Josh-Cena deleted the jc/serialize-snapshot branch April 8, 2022 03:23
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants