Skip to content

fix(v1): add key to versions.map in versions.js - #2087

Merged
yangshun merged 1 commit into
facebook:masterfrom
FeynmanDNA:master
Dec 5, 2019
Merged

yangshun merged 1 commit into
facebook:masterfrom
FeynmanDNA:master

Conversation

@FeynmanDNA

Copy link
Copy Markdown
Contributor

I noticed the v1 examples versions.js when calling map function does not provide a key.

So i added the key prop to packages/docusaurus-1.x/examples/versions/pages/en/versions.js

@FeynmanDNA
FeynmanDNA requested a review from endiliey as a code owner December 5, 2019 07:56
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 5, 2019
@docusaurus-bot

Copy link
Copy Markdown
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 5216ccd

https://deploy-preview-2087--docusaurus-2.netlify.com

@yangshun yangshun changed the title fix(v1) add react key to versions.map in versions.js fix(v1): add key to versions.map in versions.js Dec 5, 2019
@docusaurus-bot

Copy link
Copy Markdown
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 5216ccd

https://deploy-preview-2087--docusaurus-preview.netlify.com

@yangshun yangshun added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Dec 5, 2019

@yangshun yangshun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yangshun
yangshun merged commit 381ed59 into facebook:master Dec 5, 2019
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants