This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Repository navigation
Releases screenshots for SIMMC-Furniture and API calls with better heuristics (SIMMC v1.2) - #60
Closed
satwikkottur wants to merge 15 commits into
Closed
satwikkottur wants to merge 15 commits into
satwikkottur wants to merge 15 commits into
Conversation
Previous scene shouldn't depend on the action that follows it. Having looked at a few examples I think the call the get_carousel_state isn't needed.
SearchFurniture and NavigateCarousel actions result in views of the carousel so don't need to include any previous in-focus items. These are implicity removed by these two actions.
Making the "before" scenes more stable.
Screenshot fix
Leave out focus item when action is Search or Navigate
Raw actions are split by messages, not necissarily by when sharing occurs. This is especially noticible when, say, a SpecifyInfo action is inserted which doesn't often align with a share actions. Thus need to take into acount when 'Share' occurs to determine the final scene as seen by the user as the result of an one round.
Setting turn_carousel_state based on 'Share'
skiingpacman
approved these changes
Apr 15, 2021
skiingpacman
left a comment
Contributor
There was a problem hiding this comment.
Three comments (as mentioned offline), otherwise looks good.
satwikkottur
marked this pull request as ready for review
April 15, 2021 17:07
|
@satwikkottur has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@satwikkottur merged this pull request in ca31013. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.