Fix: Preserve inbound X-Forwarded-Proto through SetXForwarded - #1095
Closed
andersontechnetverrum wants to merge 1 commit into
Closed
andersontechnetverrum wants to merge 1 commit into
andersontechnetverrum wants to merge 1 commit into
Conversation
The Director-to-Rewrite migration (827dc66) added req.SetXForwarded(), which unconditionally recomputes X-Forwarded-Proto from Fabio's own connection state. This silently discards the value addHeaders() already established (preserved from a trusted upstream, or computed otherwise), breaking deployments where a TLS-terminating load balancer sits in front of Fabio and forwards plain HTTP: the load balancer's X-Forwarded-Proto: https gets overwritten back to http, which downstream apps using it to gate Secure session cookies (e.g. express-session with proxy: true) rely on to decide whether to set the cookie at all. Capture the inbound X-Forwarded-Proto before calling SetXForwarded and restore it afterward if present, mirroring the existing X-Forwarded-For preservation right above it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Director-to-Rewrite migration (827dc66) added req.SetXForwarded(), which unconditionally recomputes X-Forwarded-Proto from Fabio's own connection state. This silently discards the value addHeaders() already established (preserved from a trusted upstream, or computed otherwise), breaking deployments where a TLS-terminating load balancer sits in front of Fabio and forwards plain HTTP: the load balancer's X-Forwarded-Proto: https gets overwritten back to http, which downstream apps using it to gate Secure session cookies (e.g. express-session with proxy: true) rely on to decide whether to set the cookie at all.
Capture the inbound X-Forwarded-Proto before calling SetXForwarded and restore it afterward if present, mirroring the existing X-Forwarded-For preservation right above it.