Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2754 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 8099 8099
Branches 1131 1131
=========================================
Hits 8099 8099 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Thanks for this PR @naqiyaa!
Everything passes, as evidenced by CI, so great job from that perspective! 👍
However, before merging, I would like the tox.toml file to become more legible for the reader as well:
- Please restore all the comments from
tox.ini(unless they where specific to the INI format). TOML supports comments just fine in the same way as INI. - Please indent the file so that it is easier to read both the text itself, and future diffs. If in doubt, just use a similar structure of line breaks as it was before, i.e., if
commandswere listed on separate lines, keep that distinction.
|
|
Thanks for the review! I've updated |
|
Thanks for the prompt update @naqiyaa! |
|
Thanks for pointing that out! I've now committed and pushed the changes to the existing PR. The latest commit should be visible on GitHub. Please take another look when you get a chance! |
vytas7
left a comment
There was a problem hiding this comment.
It seems consistency with tox.ini can still be improved.
| ] | ||
|
|
||
| [env_run_base] | ||
| set_env = { PIP_CONFIG_FILE = "pip.conf", PYTHONASYNCIODEBUG = "1", FALCON_DISABLE_CYTHON = "Y" } |
There was a problem hiding this comment.
All these set_envs are still single lines, however multiple in tox.ini. Let's make them consistent.
Summary of Changes
Related Issues
Closes #2750
Pull Request Checklist
tox.docs/.docs/.docs/_newsfragments/.