Skip to content

[falcosidekick] Add Gateway API HTTPRoute support - #1026

Merged
poiana merged 1 commit into
falcosecurity:masterfrom
somaz94:feat/falcosidekick-httproute
Jun 17, 2026
Merged

[falcosidekick] Add Gateway API HTTPRoute support#1026
poiana merged 1 commit into
falcosecurity:masterfrom
somaz94:feat/falcosidekick-httproute

Conversation

@somaz94

@somaz94 somaz94 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Add Gateway API HTTPRoute support to the falcosidekick chart for both the core service and the Web UI, as an alternative to the existing Ingress resources. This follows the ingress-nginx retirement and the migration toward Gateway API described in #962.

  • New templates/httproute.yaml (core) gated by httproute.enabled
  • New templates/httproute-ui.yaml (Web UI) gated by webui.httproute.enabled
  • Mirrors the existing ingress.yaml / ingress-ui.yaml structure; both default to false, so existing installs are unaffected
  • Supports parentRefs, hostnames (templated), matches, filters, additionalRules, httpsRedirect, and apiVersion / kind overrides

Validation (local):

  • helm lint charts/falcosidekick → 0 chart(s) failed
  • helm template with defaults → no HTTPRoute rendered (disabled by default)
  • core enabled → backend <release>-falcosidekick:2801
  • Web UI enabled → backend <release>-falcosidekick-ui:2802
  • httpsRedirect=true → RequestRedirect (301) filter only
  • make docs-falcosidekick → README regenerated (helm-docs v1.11.0)

Chart version bumped 0.13.1 → 0.14.0, CHANGELOG updated.

closes #962

/kind feature
/area falcosidekick-chart

@poiana

poiana commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Welcome @somaz94! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana
poiana requested review from bencer and c2ndev June 4, 2026 05:39
@poiana poiana added the size/L label Jun 4, 2026
@somaz94
somaz94 marked this pull request as ready for review June 4, 2026 06:01
@poiana
poiana requested a review from ekoops June 4, 2026 06:02
@somaz94

somaz94 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Ready for review 🙏 This adds Gateway API HTTPRoute support for Falcosidekick and the Web UI as an alternative to Ingress — mirrors the existing Ingress conventions, defaults to disabled, and includes a NOTES.txt parity update. helm lint and template/NOTES rendering pass locally. CI is currently waiting on first-time-contributor workflow approval — could a maintainer kick it off? Thanks!

@somaz94

somaz94 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Friendly ping 🙏 — all checks are green (managed-charts, readme, test, dco) and this is ready for review. The change adds Gateway API HTTPRoute support for Falcosidekick + Web UI, mirroring the existing Ingress convention and gated behind a disabled-by-default flag.
/cc @bencer @ekoops @c2ndev

c2ndev
c2ndev reviewed Jun 16, 2026
View reviewed changes

@c2ndev c2ndev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @somaz94,
thanks for adding HTTPRoute support. The overall shape looks good. I found two small NOTES templating issues inline.

One small thing for next time: could we keep the repo's PR template structure?

Comment thread charts/falcosidekick/templates/NOTES.txt Outdated
{{- end }}
{{- else if .Values.httproute.enabled }}
{{- range .Values.httproute.hostnames }}
http{{ if $.Values.httproute.httpsRedirect }}s{{ end }}://{{ . }}/

@c2ndev c2ndev Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
http{{ if $.Values.httproute.httpsRedirect }}s{{ end }}://{{ . }}/
http{{ if $.Values.httproute.httpsRedirect }}s{{ end }}://{{ tpl . $ }}/

httproute.hostnames is documented as templated and the HTTPRoute manifest already renders it through tpl, but the NOTES output still prints the raw template string. With {{ .Release.Name }}.example.test, the route renders review.example.test while NOTES prints {{ .Release.Name }}.example.test.

Comment thread charts/falcosidekick/templates/NOTES.txt Outdated
{{- end }}
{{- else if .Values.webui.httproute.enabled }}
{{- range .Values.webui.httproute.hostnames }}
http{{ if $.Values.webui.httproute.httpsRedirect }}s{{ end }}://{{ . }}/

@c2ndev c2ndev Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
http{{ if $.Values.webui.httproute.httpsRedirect }}s{{ end }}://{{ . }}/
http{{ if $.Values.webui.httproute.httpsRedirect }}s{{ end }}://{{ tpl . $ }}/

Same for the Web UI HTTPRoute notes. webui.httproute.hostnames is documented as templated and the HTTPRoute uses tpl, so the post-install URL should render the hostname the same way.

@somaz94

somaz94 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review @c2ndev! Both NOTES suggestions applied in 867a227 — the post-install URLs for the core service and the Web UI now render hostnames through tpl . $, matching how the HTTPRoute manifest renders hostnames. So a templated hostname like {{ .Release.Name }}.example.test now prints the resolved value in NOTES instead of the raw template string. Verified with helm template --show-only templates/httproute.yaml (renders rel.example.test) and helm lint (0 failed). Will follow the repo PR template structure next time — appreciated!

@ekoops

ekoops commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Hey! Thank you for the contribution. Could you please squash the commits and add DCO? Thank you 🙏

@somaz94
somaz94 force-pushed the feat/falcosidekick-httproute branch from 867a227 to 827dbc8 Compare June 16, 2026 08:34
@somaz94
feat(falcosidekick): add Gateway API HTTPRoute support
d83e89e 
Signed-off-by: somaz <genius5711@gmail.com>
@somaz94
somaz94 force-pushed the feat/falcosidekick-httproute branch from 827dbc8 to d83e89e Compare June 16, 2026 08:36
@somaz94

somaz94 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Done @c2ndev 🙏 — squashed into a single commit (d83e89e) and signed off with DCO. All three previous commits (feature + NOTES URLs + the tpl NOTES fix) are now one feat(falcosidekick): add Gateway API HTTPRoute support commit with Signed-off-by. DCO check is green. Ready for another look — thanks for the review!

c2ndev
c2ndev approved these changes Jun 17, 2026
View reviewed changes

@c2ndev c2ndev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana poiana added the lgtm label Jun 17, 2026
@poiana

poiana commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c2ndev, somaz94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana

poiana commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 4222d3a2d1d69805469d2f80391459e88f38c423

@poiana
poiana merged commit 314187f into falcosecurity:master Jun 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c2ndev c2ndev c2ndev approved these changes
@bencer bencer Awaiting requested review from bencer
@ekoops ekoops Awaiting requested review from ekoops

Assignees

@c2ndev c2ndev

Labels

approved area/falcosidekick-chart dco-signoff: yes kind/feature New feature or request lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add HTTPRoute to falcosidekick

4 participants

@somaz94 @poiana @ekoops @c2ndev