Repository navigation
README: the animation reads at the size GitHub draws it, with a third version for narrow phones - #36
Merged
Merged
Conversation
… version for narrow phones
GitHub draws the 1280px animation in an 838px column (0.655) and the 720px phone one 254-472px wide (0.35-0.66), so their smallest text reached a visitor at 9-11.8px. Every text is now at least 19px in the wide animation, 28px in the phone one, and 35px in a new one for phones up to 374px (banner-small-{light,dark}.gif); the scene titles are larger and the line under them semibold. Same scenes and timing.
Measured with Playwright on seventeen device profiles, from 320px phones to 1920px desktops, in light and dark, through a local copy of the README laid out with the column github.com gives each width: the smallest text is 12px or more on every one, and each loads the GIF of its own theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub draws the 1280px animation in an 838px column (0.655) and the 720px phone one 254-472px wide (0.35-0.66), so their smallest text reached a visitor at 9-11.8px. Every text is now at least 19px in the wide animation, 28px in the phone one, and 35px in a new one for phones up to 374px (banner-small-{light,dark}.gif); the scene titles are larger and the line under them semibold. Same scenes and timing.
Measured with Playwright on seventeen device profiles, from 320px phones to 1920px desktops, in light and dark, through a local copy of the README laid out with the column github.com gives each width: the smallest text is 12px or more on every one, and each loads the GIF of its own theme.