Conversation
It failed on aarch64-mingw-ucrt since return VALUEs were truncated to lower 32 bit.
for better formatting
larskanis
force-pushed
the
winarm
branch
4 times, most recently
from
December 28, 2025 14:07
bee6f36 to
d5cc14d
Compare
Usage in Ractor requires to call `freeze`, but this prohibits re-usage in subsequent specs.
This works around the reported issue: libffi/libffi#905
They hang like on ruby-3.4 and 3.3.
```
../../../../ext/ffi_c/DynamicLibrary.c:239:53: warning: format specifies type 'int' but the argument
has type 'DWORD' (aka 'unsigned long') [-Wformat]
239 | snprintf(buf, size, "Failed with error %d: %s", error, message);
| ~~ ^~~~~
| %lu
```
`Ractor.make_shareable` doesn't freeze a module, since modules are Ractor-sharable by definition. But from a users perspective it is unexpected, when it isn't frozen after calling freeze. So better call super there. Now one spec needs to be adjusted to avoid modifying the module after freeze.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes compatibility to
aarch64-mingw-ucrt.Fixes #1148