Conversation
|
|
||
| for (const result of result_block) { | ||
| const link_tag = result.querySelector("a[href]") as HTMLAnchorElement; | ||
| const link_tag = result.querySelector("a[href].fuLhoc.ZWRArf") as HTMLAnchorElement; |
Contributor
There was a problem hiding this comment.
Potential infinite loop when result blocks exist but no items pass stricter selectors; start/attempts never advance.
Prompt for AI agents
Address the following comment on apps/api/src/search/v2/googlesearch.ts at line 126:
<comment>Potential infinite loop when result blocks exist but no items pass stricter selectors; start/attempts never advance.</comment>
<file context>
@@ -123,9 +123,9 @@ export async function googleSearch(
for (const result of result_block) {
- const link_tag = result.querySelector("a[href]") as HTMLAnchorElement;
+ const link_tag = result.querySelector("a[href].fuLhoc.ZWRArf") as HTMLAnchorElement;
const title_tag = link_tag ? link_tag.querySelector("span.CVA68e") : null;
- const description_tag = result.querySelector("span.FrIlee");
</file context>
This was referenced Sep 9, 2025
jerbao
pushed a commit
to jerbao/firecrawl-custom
that referenced
this pull request
Aug 22, 2026
zeekay
pushed a commit
to Dream-AI-4444/firecrawl
that referenced
this pull request
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes Google search scraping to return the correct result URLs and snippets. Addresses Linear ENG-3365 where the search endpoint returned strange descriptions.