Fix sitemap parsing (ENG-3361) - #2085
Merged
mogery merged 5 commits intoSep 2, 2025
Merged
Conversation
mogery
approved these changes
Sep 2, 2025
Comment on lines
+2
to
+12
| import { scrapeTimeout, idmux, Identity } from "./lib"; | ||
|
|
||
| let identity: Identity; | ||
|
|
||
| beforeAll(async () => { | ||
| identity = await idmux({ | ||
| name: "robots-txt", | ||
| concurrency: 100, | ||
| credits: 1000000, | ||
| }); | ||
| }, 10000); |
Member
There was a problem hiding this comment.
Please remove the idmux call -- since you don't call the API here, you don't need an Identity
mogery
deleted the
tom/eng-3361-map-is-only-returning-around-200-results
branch
September 2, 2025 12:47
jerbao
pushed a commit
to jerbao/firecrawl-custom
that referenced
this pull request
Aug 22, 2026
Co-authored-by: Gergő Móricz <mo.geryy@gmail.com>
zeekay
pushed a commit
to Dream-AI-4444/firecrawl
that referenced
this pull request
Sep 10, 2026
Co-authored-by: Gergő Móricz <mo.geryy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fix sitemap discovery and robots.txt handling so /map returns the full set of site URLs instead of stalling around ~200 (ENG-3361). We now parse sitemaps from robots.txt and the root, respect robots rules, and feed those URLs into map results with caching.
Bug Fixes
Refactors