Revise /extract's error message when no content could be fetched from URLs - #2109
Merged
Merged
Conversation
micahstairs
requested review from
mogery
and removed request for
nickscamara
September 6, 2025 03:15
nickscamara
self-requested a review
September 8, 2025 21:16
nickscamara
approved these changes
Sep 8, 2025
duyyudus
pushed a commit
to duyyudus/firecrawl
that referenced
this pull request
Sep 12, 2025
…supported (firecrawl#2109) Co-authored-by: Nicolas <nicolascamara29@gmail.com>
jerbao
pushed a commit
to jerbao/firecrawl-custom
that referenced
this pull request
Aug 22, 2026
…supported (firecrawl#2109) Co-authored-by: Nicolas <nicolascamara29@gmail.com>
zeekay
pushed a commit
to Dream-AI-4444/firecrawl
that referenced
this pull request
Sep 10, 2026
…supported (firecrawl#2109) Co-authored-by: Nicolas <nicolascamara29@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing wording led to a lot of confusion, since the URLs they were passing were usually valid.
Summary by cubic
Clarified /extract’s error when no content can be fetched, stating that URLs may be invalid, unsupported, or scraping failed. This reduces confusion and standardizes the message across logs and API responses.