Skip to content

Extract metadata from document head (ENG-3822) - #2342

Merged
amplitudesxd merged 1 commit into
mainfrom
tom/eng-3822-favicon-is-sometimes-incorrectly-returned
Oct 29, 2025
Merged

amplitudesxd merged 1 commit into
mainfrom
tom/eng-3822-favicon-is-sometimes-incorrectly-returned

Conversation

@amplitudesxd

@amplitudesxd amplitudesxd commented Oct 29, 2025

Copy link
Copy Markdown
Member

Summary by cubic

Extract metadata from the head element instead of the whole document to avoid picking tags from the body. Fixes incorrect favicon and Open Graph values in some pages (ENG-3822).

  • Bug Fixes
    • Scope all selectors to the head; fallback to the document when no head exists.
    • Use the new search root for title, favicon (rel=icon and rel*=icon), and Open Graph meta tags.
    • Prevents wrong favicon and OG fields caused by body content.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@amplitudesxd
amplitudesxd merged commit f5e6d8d into main Oct 29, 2025
8 checks passed
jerbao pushed a commit to jerbao/firecrawl-custom that referenced this pull request Aug 22, 2026
zeekay pushed a commit to Dream-AI-4444/firecrawl that referenced this pull request Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant