fix(api/scrape): document + pdf scrape loop - #2396
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/api/src/scraper/scrapeURL/index.ts">
<violation number="1" location="apps/api/src/scraper/scrapeURL/index.ts:1031">
After the document antibot fallback has already been attempted, this branch just logs and continues, leaving the surrounding while(true) loop to hit DocumentAntibotError again with unchanged state. Throw the error after logging so the loop exits instead of spinning.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
amplitudesxd
approved these changes
Nov 13, 2025
jerbao
pushed a commit
to jerbao/firecrawl-custom
that referenced
this pull request
Aug 22, 2026
zeekay
pushed a commit
to Dream-AI-4444/firecrawl
that referenced
this pull request
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes the scrape loop for document and PDF by capping anti-bot retries to a single reattempt, then skipping to prevent endless loops. Improves scraper stability and reduces noisy logs.
Written for commit 6fee5be. Summary will update automatically on new commits.