fix(api): tally system rework - #2430
Merged
Merged
Conversation
mogery
force-pushed
the
mog/fix-tally
branch
from
November 21, 2025 17:15
110df4a to
6393468
Compare
Member
Author
|
@cubic-dev-ai re-review pls |
Contributor
@mogery I've started the AI code review. It'll take a few minutes to complete. |
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/api/src/services/billing/batch_billing.ts">
<violation number="1" location="apps/api/src/services/billing/batch_billing.ts:322">
Redis enqueue for billed teams lacks error handling, so a Redis hiccup makes `supaBillTeam` reject after billing succeeds, dropping the queue item and leaving the team never tallied.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
jerbao
pushed a commit
to jerbao/firecrawl-custom
that referenced
this pull request
Aug 22, 2026
zeekay
pushed a commit
to Dream-AI-4444/firecrawl
that referenced
this pull request
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Reworked the billing tally flow to decouple billing from tally updates using a Redis-backed queue and a periodic worker. This reduces DB load and adds clear visibility into pending tallies.
Written for commit 6393468. Summary will update automatically on new commits.