(feat/partner-integrations) Rotate endpoint - #2547
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/api/src/controllers/v0/admin/rotate-api-key.ts">
<violation number="1" location="apps/api/src/controllers/v0/admin/rotate-api-key.ts:101">
P1: Non-atomic delete/insert creates data loss risk. If the insert fails after the delete succeeds, the user permanently loses their API key. Consider creating the new key first, then deleting the old one on success, or implementing a soft-delete/recovery mechanism.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Member
Author
|
@cubic re-run |
Contributor
@nickscamara I've started the AI code review. It'll take a few minutes to complete. |
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/api/src/controllers/v0/admin/rotate-api-key.ts">
<violation number="1" location="apps/api/src/controllers/v0/admin/rotate-api-key.ts:120">
P1: Security issue: When delete fails for a leaked API key, the endpoint still returns success. The caller will believe the leaked key was revoked when it remains active. Consider returning an error response or at least including a warning in the response body when the old key couldn't be deleted.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
mogery
approved these changes
Dec 12, 2025
jerbao
pushed a commit
to jerbao/firecrawl-custom
that referenced
this pull request
Aug 22, 2026
* Nick: rotate partner integration keys * Update rotate-api-key.ts
zeekay
pushed a commit
to Dream-AI-4444/firecrawl
that referenced
this pull request
Sep 10, 2026
* Nick: rotate partner integration keys * Update rotate-api-key.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds a secure endpoint for partner integrations to rotate a leaked API key. It deletes the old key and returns a new key for the same team and owner.
Written for commit 1c49a8c. Summary will update automatically on new commits.