Group General settings' loose checkboxes into an "Options" section - #4898
Open
nicitaacom wants to merge 2 commits into
Open
nicitaacom wants to merge 2 commits into
nicitaacom wants to merge 2 commits into
Conversation
13 checkboxes were added directly to the tab's scroll area with no visual grouping, interleaved with unrelated input fields and other titled sections in an order that no longer reflects any logical grouping. Move the checkbox-only settings into their own titled group, following the existing Startup / Notifications & Behavior pattern. Settings whose init function also builds an input field (Save Path, Imgur Client ID, Selection Geometry Display) are left where they are.
Two settings still rendered as bare rows floating between titled boxes with no border of their own: the selection-geometry hide timeout (now nested inside the "Selection Geometry Display" box it belongs to) and JPEG Quality (now nested inside "Save Path", since it only affects the save/upload/clipboard file format set there). Undo limit and Latest Uploads Max Size also broke the tab's visual pattern - they were two mini boxes hugging their content on the left with dead space to the right, while every other section is one full-width titled box. Merge them into a single "Limits" box, and drop the now-unused pushCompactSpinBox helper that built the old layout. Also reorder the top-level sections so save-destination settings (used on every capture) rank above the general Options toggles, which in turn rank above rarely-touched tuning knobs (Undo limit, Imgur Client ID, Selection Geometry Display) - Configuration File stays last as before.
| } | ||
| } | ||
|
|
||
| // 3 extra save destinations, each exposed as its own tool |
Collaborator
There was a problem hiding this comment.
This should not be included in this PR which is intended to just be a graphical change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
13 checkboxes in the General settings tab were added directly to the tab's scroll area with no visual grouping — interleaved with unrelated input fields (Imgur Client ID, Selection Geometry Display) in an order that didn't reflect any logical grouping, and "Undo limit"/"Latest Uploads Max Size" rendered as two mini boxes hugging their content with dead space beside them while every other section in the tab was a single full-width titled box.
Changes:
Moved the 13 checkbox-only settings into a new "Options" titled box, matching the existing "Startup" / "Notifications & Behavior" pattern
Settings whose init function also builds an input field (Save Path, Imgur Client ID, Selection Geometry Display) were left where they are, since nesting an input-bearing box inside a checkbox-only box would look wrong
Merged "Undo limit" and "Latest Uploads Max Size" into one full-width "Limits" box; removed the now-unused pushCompactSpinBox helper that built the old two-mini-box layout
Folded two settings that rendered as bare, borderless rows into the titled boxes they actually belong to: the selection-geometry hide timeout (into "Selection Geometry Display") and JPEG Quality (into "Save Path", since it only affects the save/upload/clipboard file format set there)
Reordered top-level sections so save-destination settings rank above general Options toggles, which rank above rarely-touched tuning knobs (Undo limit, Imgur Client ID, Selection Geometry Display) — "Configuration File" stays last as before
Test plan:
Build and open Configuration → General
Confirm the 13 checkboxes render inside one bordered "Options" box
Confirm "Limits" is a single full-width box with both spinboxes
Confirm the geometry timeout and JPEG Quality no longer float as separate rows
Toggle a few settings and confirm they still persist to flameshot.ini
BEFORE
AFTER 1
AFTER 2
This is much cleaner because no mess from checkboxes that needs input and just checkboxes and then again checkbox that just buried between 2 input fields
No more suffering when I scroll then scroll blocked because it decide to update some input instead of continuing scrolling