Repository navigation
fix(metrics): rename workload label to name in canary_weight metric - #1979
Open
AruneshDwivedi wants to merge 1 commit into
Open
AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
The canary_weight gauge was defined with labels ['workload', 'namespace'] but SetWeight() passes cd.Spec.TargetRef.Name which semantically is the canary 'name'. This caused a label mismatch where users could not filter by canary name in Prometheus. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
AruneshDwivedi
requested review from
aryan9600 and
stefanprodan
as code owners
October 9, 2026 00:58
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canary_weight gauge was defined with labels ['workload', 'namespace'] but SetWeight() passes cd.Spec.TargetRef.Name which semantically is the canary 'name'. This caused a label mismatch where users could not filter by canary name in Prometheus.