[ENH] Combined plot_spectra and plot_spectrum#198
Merged
TomDonoghue merged 6 commits intomainfrom Apr 13, 2021
Merged
Conversation
Member
|
I think I've updated this to all come together after merging #176 @ryanhammonds - when you get a chance, can you revisit this, and check the updates, and run some checks that it's all working / nothing goes weird? Thanks! |
ryanhammonds
commented
Apr 12, 2021
Member
|
Awesome, thanks for the checks @ryanhammonds! And thanks for this PR, I really like the update here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a point in #193.
plot_spectranot accepts 1d arrays andplot_spectrumhas been replaced byplot_spectrathroughout the module. The same has been done withplot_spectra_shading, withplot_spectrum_shadingremoved.Also,
plot_spectrumhas been aliased toplot_spectrain the __init__.py to not break anyone's code. This wasn't done forplot_spectrum_shadingsince it's not imported in the init.