Skip to content

Fix woff2 decoding - #5160

Merged
jtanx merged 1 commit into
fontforge:masterfrom
jtanx:cl
Dec 31, 2022
Merged

jtanx merged 1 commit into
fontforge:masterfrom
jtanx:cl

Conversation

@jtanx

@jtanx jtanx commented Dec 29, 2022

Copy link
Copy Markdown
Contributor

Fixes #5101

Re-reading the WOFF2 spec:

The "totalSfntSize" value in the WOFF2 Header is intended to be
used for reference purposes only. It may represent the size of
the uncompressed input font file, but if the transformed 'glyf'
and 'loca' tables are present, the uncompressed size of the
reconstructed tables and the total decompressed font size may
differ substantially from the original total size specified in
the WOFF2 Header.

Type of change

  • Bug fix

Fixes fontforge#5101

Re-reading the WOFF2 spec:

> The "totalSfntSize" value in the WOFF2 Header is intended to be
> used for reference purposes only. It may represent the size of
> the uncompressed input font file, but if the transformed 'glyf'
> and 'loca' tables are present, the uncompressed size of the
> reconstructed tables and the total decompressed font size may
> differ substantially from the original total size specified in
> the WOFF2 Header.

@skef skef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtanx
jtanx merged commit f58c03d into fontforge:master Dec 31, 2022
@jtanx
jtanx deleted the cl branch December 31, 2022 11:09
Comment thread fontforge/woff2.cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to open FontAwesome 6.2.0 WOFF2

4 participants