Skip to content

Preserve subdomain input when selecting a base domain#1375

Merged
oschwartz10612 merged 5 commits into
fosrl:devfrom
Pallavikumarimdb:Fix/domain-picker-issue
Aug 30, 2025
Merged

Preserve subdomain input when selecting a base domain#1375
oschwartz10612 merged 5 commits into
fosrl:devfrom
Pallavikumarimdb:Fix/domain-picker-issue

Conversation

@Pallavikumarimdb

Copy link
Copy Markdown
Contributor

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

This PR resolves #1373 and #1369 , where a subdomain entered before selecting a base domain was not saved when creating or editing a resource.

Changes introduced:

  • Users can safely type a subdomain before choosing a base domain without losing input.
  • Subdomain change and base domain selection now both trigger validation → ensuring state stays in sync regardless of order of operations.
  • Improved subdomain validation to ensure consistency across inputs.
  • The subdomain is sanitized (invalid characters removed).
  • If compatible, it is preserved and combined with the base domain.

How to test?

@Pallavikumarimdb Pallavikumarimdb marked this pull request as draft August 28, 2025 20:30
@Pallavikumarimdb Pallavikumarimdb marked this pull request as ready for review August 29, 2025 19:50
@oschwartz10612 oschwartz10612 merged commit d9a4f20 into fosrl:dev Aug 30, 2025
2 checks passed
@oschwartz10612

Copy link
Copy Markdown
Member

Thanks so much Pallavi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants