Fix subdomain preservation in DomainPicker when switching base domains#1383
Fix subdomain preservation in DomainPicker when switching base domains#1383arevindh wants to merge 5 commits into
Conversation
…in-picker-issue
…in-picker-issue
|
Hi @arevindh , I had a look at your fix. I see you’re clearing the subdomain input whenever the base domain is edited after a subdomain has already been entered. That definitely avoids the case where only the base domain gets saved, but it puts the burden back on the user since they need to re-enter the subdomain. I’ve already opened a PR with an alternative approach here: #1375 for similar issue. Could you verify if this resolves your concern as well? |
I haven't looked at your PR, but the subdomain does not get cleared if its valid. |
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
When a user typed a subdomain and then selected a different base domain, the subdomain value was being cleared due to
onDomainChangebeing called withsubdomain: undefined.How to test?
This should be tested on Create Resource Page and General Section of Resource Settings