fix(sqlite): tag per-migration database backups with version and prevent collisions - #3785
Open
Tyagiquamar wants to merge 2 commits into
Open
Tyagiquamar wants to merge 2 commits into
Tyagiquamar wants to merge 2 commits into
Conversation
Tyagiquamar
requested review from
miloschwartz and
oschwartz10612
as code owners
September 17, 2026 17:16
Member
|
I think ideally we want to be taking a snap shot of the database once per migration still so if one migration fails you still have a log of each successful one and can choose to restore a specific version. |
Author
|
Thanks for the feedback, @oschwartz10612! That makes total sense. I have updated the PR to keep per-migration database snapshots:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content.
Fixes the remaining half of #3761 (the timestamp naming was fixed by #3769; this covers the duplicate backups).
Root cause
In \server/setup/migrationsSqlite.ts, \executeScripts()\ called \�ackupDb()\ inside the per-migration loop, so upgrading across N versions produced N backups, one before each migration. Each later backup contains the earlier migrations' changes, so none of them is a clean pre-upgrade restore point (and when two migrations run within the same second, the second backup silently overwrites the first under the identical timestamped name).
Fix
Take one backup before any pending migration runs. Skipped when there is nothing to run or \DISABLE_BACKUP_ON_MIGRATION\ is set, same as before. The Postgres path never took per-migration backups, so no change was needed there.
Verification (Docker, node:24.18.1-bookworm, matching CI)
Seeded a scratch sqlite db at version 1.21.0 (pending: 1.22.0, 1.23.0) and ran the real \server/setup/migrationsSqlite.ts:
Run the new test with:
px tsx server/setup/migrationsSqlite.backup.test.ts\ (after
pm ci,
pm run set:sqlite,
pm run set:oss).